[release-1.27] fix(e2e): Add cleanup trap to prevent false positives in CI test runs #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e test script was storing the Ginkgo exit code but could still exit unexpectedly before cleanup, causing CI to mark incomplete test runs as successful (false positives). Signed-off-by: Francisco Herrera <[email protected]>
TEMPORARY FAILURE: check failure test on CI Signed-off-by: Francisco Herrera <[email protected]>
Fix lint messages Signed-off-by: Francisco Herrera <[email protected]>
This reverts commit 5346be9. Signed-off-by: Francisco Herrera <[email protected]>
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.27 #1232 +/- ##
================================================
- Coverage 77.81% 77.52% -0.29%
================================================
Files 44 44
Lines 2817 2817
================================================
- Hits 2192 2184 -8
- Misses 520 525 +5
- Partials 105 108 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FilipB
approved these changes
Sep 26, 2025
Fix lint issues in branch 1.27 Signed-off-by: Francisco Herrera <[email protected]>
istio-testing
merged commit e185785
into
istio-ecosystem:release-1.27
17 of 18 checks passed
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: [release-1.27] fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1232) fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: [release-1.27] fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1232) fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 6, 2025
* upstream/release-1.27: [release-1.27] fix(e2e): Add cleanup trap to prevent false positives in CI test runs (istio-ecosystem#1232) fix: remove MeshConfig from ZTunnel CRD (istio-ecosystem#1236) (istio-ecosystem#1251)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1227